search

files-community / Files

Building the best file manager for Windows
https://files.community
MIT License
33.77k stars 2.16k forks source link

Feature: Add access keys to the context menu #7505

Open chaoscreater opened 2 years ago

chaoscreater commented 2 years ago

What's the Problem?

In normal Windows 10 Explorer, you can right click and press an Access Key shortcut on your keyboard to open certain menus.

For example, right click in blank space or right lcick on file/folder and press:

Those are not currently supported in Files.

You can check out what Access Keys shortcuts are available by toggling this setting: image

You can see the underlined letter when you right click: image

Solution/Idea

Add Access Keys shortcut support.

Alternatives

no alternatives at the moment.

Priorities

Capability Priority
This proposal will allow developers to accomplish W Must
This proposal will allow end users to accomplish X Should
This proposal will allow developers to accomplish Y Could
This proposal will allow end users to accomplish Z Won't

Files Version

Version: 2.0.34.0

Windows Version

Windows 10 21H2 Build 19044.1348

Comments

No response

yaira2 commented 2 years ago

@winston-de does the command bar flyout support access keys?

chaoscreater commented 2 years ago

I'm assuming you mean this? image

Then no, it doesn't and that is exactly the issue. Right click in normal Explorer.exe and then press an access key should trigger something (e.g. open file/folder properties with 'R' key). Right click in Files and then press an access key does not trigger anything.

winston-de commented 2 years ago

They do work, but the UI isn't great For example, the access key is not underlined like a they are in explorer. The access key also only shows and works when you press alt, and will only show for the part of the CommandBarFlyout that is focused (primary or secondary bar).

image image

We could probably make our own implementation that underlines the letter and listens for key press events to trigger the action.

yaira2 commented 1 year ago

@cinqmilleans is this part of the custom actions?

0x5bfa commented 4 months ago

We could implement our own TextBlock and MenuFlyoutItem to adopt with the TextBlock. The underlined text is actually created like 'A&dd' and 'D&elete' to notify the win form of the access key's availability.

Do we really need this, btw? Putting underline doesn't sounds right to me.

yaira2 commented 4 months ago

The latest design from WinUI doesn't seem to use underlines. the main thing is that they should display when pressing alt.