Upgrading Finagle's HTTP requests

finagle / finagle-websocket

Finagle Websocket clients and servers

35 stars 23 forks source link

Upgrading Finagle's HTTP requests #13

Open tindzk opened 8 years ago

tindzk commented 8 years ago

I am currently migrating a server from akka-http to Finagle. The only thing left to port is one WebSocket endpoint. Unfortunately, I couldn't manage to find a way to upgrade an existing HTTP request to a WebSocket connection. It is possible to respond with a 101 message, but Finagle drops the Connection: Upgrade header which is required. Furthermore, it doesn't seem to be possible to access reader and writer and pipe those streams into an HttpWebSocket.

luciferous commented 8 years ago

There isn't yet a story to upgrade from finagle-http to finagle-websocket if that's what you're after. You have to pick one. If you describe your app, we may be able to suggest a temporary workaround.