search

final-form / react-final-form-html5-validation

A swap-in replacement for 🏁 React Final Form's <Field> component to provide HTML5 Validation
MIT License
57 stars 8 forks source link

Field continues to be required even after changing required prop to false #19

Open TylerRick opened 5 years ago

TylerRick commented 5 years ago

Are you submitting a bug report or a feature request?

Bug report

What is the current behavior?

If required prop is initially true, then the validate function continues to require the field to be filled in, even if you later change the required prop to false.

What is the expected behavior?

As soon as required prop changes, validation checks should reflect that that. So if you change it to false, the field should no longer be required.

Sandbox Link

https://codesandbox.io/s/react-final-form-html5-validation-example-n2q8d

Other information

Likely related to #13

TylerRick commented 5 years ago

Note that the problem goes away if you change it to use the Field from 'react-final-form' instead.

TylerRick commented 5 years ago

As a workaround, you can set key to the same thing as you set required prop to. But we shouldn't have to resort to this, should we??