search

finitespace / BME280

Provides an Arduino library for reading and interpreting Bosch BME280 data over I2C, SPI or Sw SPI.
GNU General Public License v3.0
212 stars 105 forks source link

absolute humidity #58

Closed coelner closed 6 years ago

coelner commented 6 years ago

an implementation for absolute humidity

finitespace commented 6 years ago

This pull has conflicts after merging heat index. Please pull the latest version of trunk and resolve the conflicts.

finitespace commented 6 years ago

Thanks for adding all of these!

finitespace commented 6 years ago

This still has heat index modifications in it but it doesn't conflict. So I am wondering if this merge will cause a duplication. What did you do to fix the pull?

coelner commented 6 years ago

I did a rebase with your master (after you accept the pull request) and fix a minor conflict in the keywords. I am not sure, but the github web based view is somehow broken. If you switch to my repo in the correspending branch, you will see a correct web view.

finitespace commented 6 years ago

I am hesitant that this will mess up files the way it is displaying the changes. I would like to merge it to a new branch and then back to master to ensure the changes are correct.

finitespace commented 6 years ago

There are also compilation issues in this pull request. Again, please make sure you run your code before submitting a pull request. Thanks!

finitespace commented 6 years ago

@coelner is there a reason you used double as the return for absHum? Is there an overflow? It is just not consistent with other functions.