add commonjs as extend file

finn-no / eslint-config-finn

ESLint config for Finn.no

2 stars 3 forks source link

add commonjs as extend file #4

Closed sveisvei closed 8 years ago

SimenB commented 8 years ago

What's the diff with this and finn/node?

Use case, I mean, I get that rules are different 😄

sveisvei commented 8 years ago

node includes all kinds of more "stuff" than module and exports :). But if its only this key/prop for es5 commonjs browser modules im not sure its needed.

gregersrygg commented 8 years ago

Why should we allow commonjs for browser modules when they can use ES modules?

sveisvei commented 8 years ago

Allow for new stuff, no, but for old stuff. BUT, closing this, likely yagni.