search

finos / FDC3-conformance-framework

A framework for testing whether desktop containers implement the FDC3 standard
Apache License 2.0
14 stars 15 forks source link

Do NOT use joinChannel on App Channels #121

Closed kriswest closed 1 year ago

kriswest commented 2 years ago

@Joe-Dunleavy @osouthwell-scottlogic @robmoffat The 1.2 open tests are still using fdc3.joinChannel calls for app channels - as previously discussed you must use fdc3.getOrCreateChannel on app channels NOT fdc3.joinChannel: https://github.com/finos/FDC3-conformance-framework/blob/14b1ea628fa572c2a7dfbd5c7bed8e476c88d6e0/src/test/v1.2/advanced/fdc3.open.ts#L31

and your receiver needs to use the channel object NOT the top level fdc3.addContextListener (which is for user/system channels): https://github.com/finos/FDC3-conformance-framework/blob/14b1ea628fa572c2a7dfbd5c7bed8e476c88d6e0/src/test/v1.2/advanced/fdc3.open.ts#L252

You'll need to fix this both in the test definition and the mock apps (which still contain JS in a script tag): https://github.com/finos/FDC3-conformance-framework/blob/14b1ea628fa572c2a7dfbd5c7bed8e476c88d6e0/static/v1.2/general/index.html#L16-L38

This applies to both 1.2 and 2.0 mock apps (I've only provided references for 1.2)

Joe-Dunleavy commented 2 years ago

This PR resolves this in both 1.2 and 2.0: https://github.com/finos/FDC3-conformance-framework/pull/140

kriswest commented 1 year ago

resolved