Promises refactor plus bugfix

finos / FDC3-conformance-framework

A framework for testing whether desktop containers implement the FDC3 standard

Apache License 2.0

14 stars 15 forks source link

Promises refactor plus bugfix #144

Closed robmoffat closed 1 year ago

robmoffat commented 2 years ago

Hi Guys,

I've reviewed all the app-channel and user-channel tests against the spec, based on our discovery yesterday that we weren't passing in the context type into addContextListener properly.

Can we review this? I've run this against my local finsemble - would be nice to know how this works on Glue too.

This PR builds on top of @ksgeorgieva 's promises-refactor PR.

kriswest commented 2 years ago

FYI refactor-test-app-channels / PR #142 adds one commit to promises-refactor / #138 hence I suggest that:

we close #138
retarget this PR #144 at #142's branch (refactor-test-app-channels)
review and merge this PR
return to #142 and check off which comments are now resolved by your changes
continue forward with #142 and try to get that merged to main when comments are dealt with