search

finos / community

FINOS Community, Project and SIG wide collaboration space
http://community.finos.org
61 stars 26 forks source link

Changing Whitesource link broken to the functional link in intro #274

Closed josspo closed 11 months ago

josspo commented 11 months ago

Whitesource page was 404, changing this to a functional link

netlify[bot] commented 11 months ago

Deploy Preview for eager-borg-83c1a5 ready!

Name Link
Latest commit f49345d57e1125b152d16aa329bcd7bf69ccbc4e
Latest deploy log https://app.netlify.com/sites/eager-borg-83c1a5/deploys/64945fb015075200084a8d33
Deploy Preview https://deploy-preview-274--eager-borg-83c1a5.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

maoo commented 11 months ago

Thanks for the PR @josspo - but we don't need to merge it, since the issue is not in the link.

You faced a problem because you accessed https://community.finos.org/docs/development-infrastructure/code-validation/intro/ (note the last trailing /), instead of https://community.finos.org/docs/development-infrastructure/code-validation/intro

With the final /, no links work, whereas without it, everything works as expected.

As a general rule, it's always a good idea to use relative paths, to make your web logic portable (what if we decide to change domain name, or navigation structure? you'd need to change all these links).