search

fippo / rtcstats

MIT License
128 stars 41 forks source link

test: fix them #53

Closed fippo closed 7 years ago

fippo commented 7 years ago

another attempt at fixing the tests

fippo commented 7 years ago

since @manasdpradhan asked... this shows a real problem in Firefox actually.

fippo commented 7 years ago

so the issue is that the test calls removeStream in Firefox. Which does not exist. It seems to fail independent of rtcstats (i.e. when I remove rtcstats from the testpage.html file) but for reasons I don't understand this passes in adapter (and now here again).

I mangled things not to attempt wrapping removeStream. In general the checks for wrapping something need to be conditional on the existence of the native method. But after this is merged :-)

fippo commented 7 years ago

we ran into issues with both chromedriver and geckodriver on adapter recently so had to pin them :-/