firebase / codelab-friendlychat-ios

Apache License 2.0
68 stars 51 forks source link

Multiple build issues #241

Open claresudbery opened 5 months ago

claresudbery commented 5 months ago

Hi I am trying to follow this tutorial but there have been multiple issues:

claresudbery commented 5 months ago

Hi I managed to get an application ID and get the code running, but now the tutorial says I need to add the line "GIDSignIn.sharedInstance().delegate = self" to the didFinishLaunchingWithOptions application function in AppDelegate.swift. This is the line of code I had to comment out before, because GIDSignIn has changed and the shared instance no longer has a delegate property. I checked the migration guide for google Signin, but it didn't help me work out how to fix this. migration guide: https://developers.google.com/identity/sign-in/ios/quick-migration-guide

claresudbery commented 5 months ago

I have created a PR of the changes I needed to make to get the app to build and run: https://github.com/firebase/codelab-friendlychat-ios/pull/242 See notes in the PR though - I believe there is still work needed to get the GIDSignIn stuff working. Also anyone using this code will need to add their own app id into info.plist (currently line 63).