firebase / firebase-admin-dotnet

Firebase Admin .NET SDK
https://firebase.google.com/docs/admin/setup
Apache License 2.0
369 stars 131 forks source link

Link, ClickAction Https Validation, before request. #346

Open Davidos533 opened 1 year ago

Davidos533 commented 1 year ago

[REQUIRED] Step 2: Describe your environment

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

I trying to send a push messaage with: -Webpush data (FcmOptions.Link) -Android data (Notification.ClickAction)

Link and ClickAction same, this is http links, not https, because this is my local development enviroment. When i developing i want to send messages with http links that pointing on my local circuit wtihout https.

Before message sends, it's validating, and validation checks link only in webpush, Android click action does not checks, and if link not https throws exception with mesage:

System.ArgumentException: 'The link options should be a valid https url.'

image

I want to have a opportunity to disable this validation, but in best case scenario remove this validation from code, beacause i dowloaded source code, and used it instead of package, after removing https checks, and FCM succeffully processed this message, when i got it and clicked on message, my browser successfully opened on http - link.

this place in source code:

using System;
using Newtonsoft.Json;

namespace FirebaseAdmin.Messaging
{
    public sealed class WebpushFcmOptions
    {
        [JsonProperty("link")]
        public string Link { get; set; }

        internal WebpushFcmOptions CopyAndValidate()
        {
            var copy = new WebpushFcmOptions()
            {
                Link = this.Link,
            };

            if (copy.Link != null)
            {
            // this https validation, that i want to remove
                if (!Uri.IsWellFormedUriString(copy.Link, UriKind.Absolute) || !copy.Link.StartsWith("https"))
                {
                    throw new ArgumentException("The link options should be a valid https url.");
                }
            }

            return copy;
        }
    }
}

Relevant Code:

using FirebaseAdmin;
using FirebaseAdmin.Messaging;
using Google.Apis.Auth.OAuth2;

var credential = GoogleCredential.FromFile("private-key.json");

FirebaseApp.Create(new AppOptions()
{
    Credential = credential
});

var registrationToken = "CLIENT_TOKEN_HERE";

var message = new Message()
{
    Token = registrationToken,
    Notification = new Notification()
    {
        Title = "Test title.",
        Body = "Test body.",

    },
    Webpush = new WebpushConfig()
    {
        FcmOptions = new WebpushFcmOptions()
        {
        // http link that will be cheked
            Link = "http://127.0.0.1:5173"
        }
    },
    Android = new AndroidConfig()
    {
        Notification = new AndroidNotification()
        {
        // this will not checked
            ClickAction = "http://127.0.0.1:5173"
        }
    }
};

var response = await FirebaseMessaging.DefaultInstance.SendAsync(message);

Console.WriteLine($"Successfully send message to {response}");
google-oss-bot commented 1 year ago

I found a few problems with this issue: