Update dagger to 2.24 - Githubissues

firebase / firebase-android-sdk

Firebase Android SDK

https://firebase.google.com

Apache License 2.0

2.29k stars 579 forks source link

Update dagger to 2.24 #712

Closed hameno closed 5 years ago

hameno commented 5 years ago

What feature would you like to see?

Newer dagger version (2.24+) so that we can upgrade our app. This currently fails with:

dagger.android.support.DaggerApplication_MembersInjector: can't find referenced method 'void injectBroadcastReceiverInjector(dagger.android.DaggerApplication,dagger.android.DispatchingAndroidInjector)' in program class dagger.android.DaggerApplication_MembersInjector

How would you use it?

n/a

google-oss-bot commented 5 years ago

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

ashwinraghav commented 5 years ago

Thanks for notifying us. Seems like this needs to change across inappmessaging and transport runtime!

ThomasSunderland commented 4 years ago

FYI: After updating our app to from Firebase Messaging version 20.0.1 to version 20.1.0 I am now getting duplicate Dagger class errors. Our app uses Dagger version 1.2.5. I will open a new issue stating the same.