firebase / firebase-ios-sdk

Firebase SDK for Apple App Development
https://firebase.google.com
Apache License 2.0
5.69k stars 1.49k forks source link

[Auth] Add objc attribute to UserInfoImpl so legacy decoding works #14169

Closed ncooke3 closed 3 days ago

ncooke3 commented 3 days ago

The class names was changed from FIRUserInfoImpl to UserInfoImpl, but the unarchiving older copies (pre name change) requires knowing the original ObjC name. The rest of the direct/transitive types from the User class's init?(coder:) look okay.

We actually do this for other classes, I just had to make the connection that the class wasn't being decoded because the pre-11 archive didn't have a blob mapping to "UserInfoImpl". The blob was mapping to "FIRUserInfoImpl".

https://github.com/firebase/firebase-ios-sdk/blob/700fd6803d50275be326c356b400704f2ea8b481/FirebaseAuth/Sources/Swift/SystemService/AuthAppCredential.swift#L18-L19

Fix #14011