search

firebug / websocket-monitor

Not compatible with Firefox Quantum (57 and newer)
Other
146 stars 18 forks source link

WiP: Add eslint and travis #60

Closed eliihen closed 8 years ago

eliihen commented 8 years ago

Oh boy. Looks like we got our work cut out for us.

I added the eslint config that you linked in #59, as well as some websocket-monitor-specific overrides to make it run. To run ESLint, simply run npm run eslint.

The .eslint.mozilla file is untouched, so you can just wget replace it when a change is made.

I also added travis CI integration, so that all pushes and Pull Requests will trigger ESLint.

Do the results on this link look about right for you, @janodvarko? I can probably fix most of the issues before we merge this PR if you just confirm that the errors look correct. https://travis-ci.org/esphen/websocket-monitor/builds/132337769

janodvarko commented 8 years ago

Errors looks ok to me. It's likely that we are not going to like all the styles, but important is to be consistent...

(you can create new PR for fixes)

Honza

janodvarko commented 8 years ago

Yeah, there is work to do, but we can fix the code step by step.

Thanks! Honza