search

firecow / gitlab-ci-local

Tired of pushing to test your .gitlab-ci.yml?
MIT License
2.4k stars 135 forks source link

feat: use re2 regex engine for rule evaluation #1411

Closed ANGkeith closed 1 week ago

ANGkeith commented 2 weeks ago

resolves #932

firecow commented 1 week ago

@ANGkeith You got any idea if this has any performance impacts? Noticed anything?

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ANGkeith commented 1 week ago

@firecow did not really took too much note regarding performance...

But at least based on the integration test time taken.. , i don't see too much increase in the execution time

firecow commented 1 week ago

Alright, lets try it out. I'm publishing a new release soon, are we ready for that? @ANGkeith

ANGkeith commented 1 week ago

yup, lets do it !