Handle buffer_size 0 correctly

firehoseio / firehose

Build realtime Ruby web applications. Created by the fine folks at Poll Everywhere.

http://firehose.io/

MIT License

727 stars 72 forks source link

Closed mrpinsky closed 5 years ago

mrpinsky commented 5 years ago

Previously, if buffer_size was set to 0, we would execute

LTRIM list_key 0 -1

which keeps the entire list (LTRIM's arguments specify the range to keep, inclusive, and the indices wrap so that -1 represents the last element).

bakkdoor commented 5 years ago

Looks like this is failing CI. Did the tests pass locally on your machine?