fireice-uk / xmr-stak

Free Monero RandomX Miner and unified CryptoNight miner
GNU General Public License v3.0
4.05k stars 1.79k forks source link

NH rejects a lot of shares #1337

Open kranimantas opened 6 years ago

kranimantas commented 6 years ago

When I start the miner, it works well for about an hour, and then the hell breaks loose: I keep getting different errors: from "Share not found" to "Share above target". And these aren't one offs, the errors come in batches, and eventually almost all of the shares become bad.

nh

With 2.2.0 there were no issues, and now the configuration is exactly the same, but I'm getting a ton of rejections. No changes in hardware, temperatures normal, no other errors or suspicious symptoms.

After a restart, everything works well for a while again, and then the rejections start happening. CAST works fine, comparable to 2.2.0 (some errors, but less than 3 percent of shares are bad).

Could this be some kind of a loop / memory leak problem that makes all the shares bad? After a restart of the miner, it works well for a while again.

Basic information

Issue with the execution

Stability issue

perestoronin commented 6 years ago

On two same systems with Ryzen 7 1800X and Vega 56 have same "Invalid results", od = 0 `RESULT REPORT Difficulty : 120001 Good results : 608 / 728 (83.5 %) Avg result time : 90.4 sec Pool-side hashes : 72960608

Top 10 best results found: | 0 | 329070827 | 1 | 66694913 | | 2 | 34855625 | 3 | 10903356 | | 4 | 5552948 | 5 | 4675654 | | 6 | 4632426 | 7 | 4490612 | | 8 | 4303550 | 9 | 3950996 |

Error details: | Count | Error text | Last seen | | 117 | AMD Invalid Result GPU ID 0 | 2018-04-06 21:16:07 | | 3 | Block expired | 2018-04-06 10:36:15 |`

`Difficulty : 120001 Good results : 588 / 715 (82.2 %) Avg result time : 99.5 sec Pool-side hashes : 28920241

Top 10 best results found: | 0 | 36466056 | 1 | 11053223 | | 2 | 10582007 | 3 | 9775265 | | 4 | 9311790 | 5 | 9232523 | | 6 | 8577160 | 7 | 8261969 | | 8 | 7946579 | 9 | 7703713 |

Error details: | Count | Error text | Last seen | | 124 | AMD Invalid Result GPU ID 0 | 2018-04-06 21:15:15 | | 3 | Block expired | 2018-04-06 09:21:43 |`

How to fix this ? Any help will nicely!

May be errors from this warning from some pools ? You must update your XMR miners before block 1546000 (April 6th) or they will STOP working

psychocrypt commented 6 years ago

monero hash forked therefore please update to the latest miner if you try to mine monero. https://github.com/fireice-uk/xmr-stak/releases

kranimantas commented 6 years ago

This is the 2.4.2 misbehaving, unfortunately.

perestoronin commented 6 years ago

and for me, miners and problems with errors as above # xmr-stak -V Version: xmr-stak/2.4.2/

psychocrypt commented 6 years ago

please post the config files

hchan123 commented 6 years ago

I have the same issue when mining against the cryponightv7 pool on nicehash using 2.4.2. The miner would mine fine for about an hour and then I will start getting above target error for results after.

On Fri, Apr 6, 2018 at 2:39 PM, perestoronin notifications@github.com wrote:

and for me, miners and problems with errors as above

xmr-stak -V Version: xmr-stak/2.4.2/

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fireice-uk/xmr-stak/issues/1337#issuecomment-379340803, or mute the thread https://github.com/notifications/unsubscribe-auth/AiOxvfCAOmL5X_sn6GD7bvfHiBjZB1Xpks5tl7ZYgaJpZM4TKefF .

psychocrypt commented 6 years ago

please also post the error output (press key 'r') wee need to know the error type

perestoronin commented 6 years ago

gpu_threads_conf" : [ // gpu: gfx900 memory:8048 // compute units: 56 { "index" : 0, "intensity" : 1792, "worksize" : 8, "affine_to_cpu" : true, "strided_index" : 1, "mem_chunk" : 2, "comp_mode" : true },

kranimantas commented 6 years ago

Error messages (could be different):

Share above target. 8 | 2018-04-06 11:26:35 Job not found. 1 | 2018-04-06 11:22:30

Config: { "index" : 0, "intensity" : 1800, "worksize" : 8, "affine_to_cpu" : 2, "strided_index" : true, "mem_chunk" : 2, "comp_mode" : true }, { "index" : 0, "intensity" : 1932, "worksize" : 8, "affine_to_cpu" : 4, "strided_index" : true, "mem_chunk" : 2, "comp_mode" : true },

g-hash commented 6 years ago

on intensities 1896 and 1900, my Vega 56 was getting a lot of these errors: "AMD Invalid Result GPU ID 0"

Lowered intensity to 512 and only had 2 of this error so far, but hash rate is 1 third what it should be.

Edit: Running 2.4.2 downloaded on 4/5

Bathmat commented 6 years ago

I am also seeing many AMD Invalid Result GPU ID 1

I was testing with Wownero (fork of XMR with V7 from the start) over the last couple of days, and noticed about 2% worth of those errors using the same configs that I was using pre-V7.

I have a mix of RX470/480/570/580 and they all seem to have similar results. They are all bios-modded and OC'd with 2000-2100 mem clocks, and I run 2 threads per gpu. This configuration was working great pre-V7 with no issues.

Sample config:

  // gpu: Ellesmere memory:3712
  // compute units: 36
  { "index" : 0,
    "intensity" : 896, "worksize" : 8,
    "affine_to_cpu" : false, "strided_index" : 1, "mem_chunk" : 2,
    "comp_mode" : true
  },
  { "index" : 0,
    "intensity" : 896, "worksize" : 8,
    "affine_to_cpu" : false, "strided_index" : 1, "mem_chunk" : 2,
    "comp_mode" : true
  },

Version 2.4.1

EDIT: I am testing with "comp_mode" : false now and will update with the results.

EDIT2: After testing with "comp_mode" : false for about an hour, I have not seen any AMD Invalid Result GPU ID 1. I forgot to mention that I am using Win10 and AMD Blockchain driver with my original submit. If "comp_mode" : true is a fix to use with non-blockchain drivers, I apologize for wasting this post. I'll update if anything changes. Thanks.

randelsr commented 6 years ago

I can confirm that on 2.4.2, CNv7, I thought this was resolved but now seeing a ton of "Result rejected by the pool" ->> Share above target.

Spudz76 commented 6 years ago

pools.txt is the more relevant config file...

makew0rld commented 6 years ago

I am getting the same thing, mine says Incorrect hashing protocol in use, and Low difficulty share. I assume this is because of the hard fork.

g-hash commented 6 years ago

@Bathmat I tried the "comp_mode" : false and it's giving a lot less AMD Invalid Result GPU ID 0 errors (3 out of 190 since the last restart of xmr-stak). Was able to use 1536 intensity so hash rate is decent if not back to 'normal'.

GiulioPipitone commented 6 years ago

Same error here. Version 2.4.2, monero7 protocol, Ryzen3 2200G (cpu and gpu embedded), dwarfpool. It works accepting shares for a while then suddenly only "result rejected" for a while, then "result accepted" again....and so on. Configuration attached (made using online tool+minor tweeking on amd file)

ERROR.txt ERRORAMD.txt ERRORCONFIG.txt ERRORCPU.txt ERRORPOOLS.txt

madscientist159 commented 6 years ago

Seeing this same problem with just the basic CPU miner, no GPU. Latest GIT.

Error details:
| Count | Error text                       | Last seen           |
|   259 | Share above target.              | 2018-04-07 08:15:11 |
|     2 | [NETWORK ERROR]                  | 2018-04-07 07:13:00 |
Bathmat commented 6 years ago

@g-hash I also saw a lot better results after running all night with "comp_mode" : false . Only about half of my rigs show AMD Invalid Result GPU ID 0, and they were far less than previously (below 1% now). I might try decreasing the intensity a little to see if I can eliminate them completely, but for now, this is much better.

Spudz76 commented 6 years ago

I am unable to reproduce, nanopool worked perfectly throughout the entire hard fork process.

You certainly should not run comp_mode unless you didn't bother to make intensity evenly divisible by worksize. It is a safety for those too lazy to do math or tune their own settings, it will result in running (at any rate more than zero / probably non optimal) instead of crashing, which is the only point of compensating.

If you turn comp_mode false and then experience crashes with otherwise working settings, then your settings aren't correctly divisible. The correct target setting for comp_mode is false.

psychocrypt commented 6 years ago

@GiulioPipitone I can not reproduce you issues. All work fine If I try it

Spudz76 commented 6 years ago

Same here, no issue, even used the identical pool.txt except stuffed my XMR wallet in there (even though I will never mine to paylevel on dwarfpool probably...)

Version: xmr-stak/2.3.0/3c99494/dev/win/cpu/aeon-cryptonight-monero/0:

[2018-04-07 15:57:04] : Result accepted by the pool.
[2018-04-07 15:59:59] : New block detected.
[2018-04-07 16:00:44] : New block detected.
[2018-04-07 16:02:23] : Result accepted by the pool.
[2018-04-07 16:02:59] : Result accepted by the pool.
[2018-04-07 16:03:24] : Result accepted by the pool.
RESULT REPORT
Difficulty       : 20000
Good results     : 4 / 4 (100.0 %)
Avg result time  : 161.5 sec
Pool-side hashes : 80000

Top 10 best results found:
|  0 |           394760 |  1 |           224693 |
|  2 |           137948 |  3 |            51861 |
|  4 |                0 |  5 |                0 |
|  6 |                0 |  7 |                0 |
|  8 |                0 |  9 |                0 |

Error details:
Yay! No errors.

...also tried xmr-stak/2.4.1/5ce9892/dev/win/nvidia-amd-cpu/aeon-cryptonight-monero/0:

[2018-04-07 16:08:19] : Fast-connecting to xmr-eu.dwarfpool.com:8005 pool ...
[2018-04-07 16:08:19] : Pool xmr-eu.dwarfpool.com:8005 connected. Logging in...
[2018-04-07 16:08:19] : Difficulty changed. Now: 20000.
[2018-04-07 16:08:19] : Pool logged in.
[2018-04-07 16:09:54] : Result accepted by the pool.
[2018-04-07 16:12:17] : New block detected.
[2018-04-07 16:13:11] : Result accepted by the pool.
[2018-04-07 16:14:07] : Result accepted by the pool.
[2018-04-07 16:16:30] : Result accepted by the pool.
[2018-04-07 16:16:42] : Result accepted by the pool.
RESULT REPORT
Difficulty       : 20000
Good results     : 5 / 5 (100.0 %)
Avg result time  : 101.8 sec
Pool-side hashes : 100000

Top 10 best results found:
|  0 |            47250 |  1 |            42574 |
|  2 |            37360 |  3 |            28398 |
|  4 |            20681 |  5 |                0 |
|  6 |                0 |  7 |                0 |
|  8 |                0 |  9 |                0 |

Error details:
Yay! No errors.

OK, also tried xmr-stak/2.4.2/945524b/dev/win/cpu/aeon-cryptonight-monero/0:

CONNECTION REPORT
Pool address    : xmr-eu.dwarfpool.com:8005
Connected since : 2018-04-07 16:22:59
Pool ping time  : 227 ms

Network error log:
Yay! No errors.
RESULT REPORT
Difficulty       : 20000
Good results     : 4 / 4 (100.0 %)
Avg result time  : 105.8 sec
Pool-side hashes : 80000

Top 10 best results found:
|  0 |           185726 |  1 |           117772 |
|  2 |            34057 |  3 |            22173 |
|  4 |                0 |  5 |                0 |
|  6 |                0 |  7 |                0 |
|  8 |                0 |  9 |                0 |

Error details:
Yay! No errors.
HASHRATE REPORT - CPU
| ID |    10s |    60s |    15m | ID |    10s |    60s |    15m |
|  0 |   38.0 |   37.3 |   (na) |  1 |   39.7 |   38.9 |   (na) |
|  2 |   53.4 |   52.1 |   (na) |
Totals (CPU):   131.2  128.2    0.0 H/s
-----------------------------------------------------------------
Totals (ALL):    131.2  128.2    0.0 H/s
Highest:   139.6 H/s
-----------------------------------------------------------------
Spudz76 commented 6 years ago

I am wondering if much of this pool connection errors problem (that should not exist) is a new wormware that installs a hidden socket proxy in Windows and modifies mining traffic to known target pools. The hard fork made them show up because the proxyworm is now speaking the wrong language? (need to get infected with an updated trojan, haha)

Every pool comm problem since the fork seems to be both mysterious and on Windows only... also given nobody using TLS so it would be trivial for a hidden proxy service to swap wallet payout ids (skimming) or whatever it wanted (make your shares invalid if it can't steal from you / revenge).

psychocrypt commented 6 years ago

@kranimantas maybe #1437 is solving your issue. #1437 will be merged into the dev branch if it passed the review

psychocrypt commented 6 years ago

could you please check if #1526 is fixing the issue

perestoronin commented 6 years ago

RESULT REPORT Difficulty : 120001 Good results : 17 / 20 (85.0 %) Avg result time : 43.6 sec Pool-side hashes : 2040017

nothing changes