search

fireice-uk / xmr-stak

Free Monero RandomX Miner and unified CryptoNight miner
GNU General Public License v3.0
4.05k stars 1.8k forks source link

Can you add a new algo? #2043

Closed Cideg closed 5 years ago

Cideg commented 5 years ago

Please add the algo: CN-Heavy-Fast http://207.180.227.127/ Many thx

psychocrypt commented 5 years ago

what is cn-heavy fast please add links ro the description and coin which using the algo

ClashLuke commented 5 years ago

CN-Heavy-Fast is an algorithm which focuses less on GPU resistance and a lot more on ASIC resistance. It allows users to get approximately x5 the hashrate they would get in CN (normal). This is done by reducing the number of iterations from two to the power of nineteen (2^19) to two to the power of twelve (2^12). As of right now, the only coin using this algorithm is bitstream, which has to use a fast halshing algorithm which also uses a big scratchpad. Hence the creation of Cryptonight-Heavy-Fast. Since the only alternation is the number of iterations, the variations of cryptonight (v1, from monero v7; v2 from monero v8) can still be implemented in CN-Heavy-Fast. A link to bitstreams github (for reference) is here https://github.com/BitStream-Project/BitStream

psychocrypt commented 5 years ago

please provide a link to a pool. we reqired a minimal hashrate. For that algo the coin should have more than 30MH/s

Cideg commented 5 years ago

http://207.180.227.127/

Spudz76 commented 5 years ago

Network Hash Rate: 280.73 H/sec

So there is one cpu on the network? Super popular.

Cideg commented 5 years ago

LOL then compile the GPU miner and off you go :-)

ClashLuke commented 5 years ago

Excuse me, but what the **** are you doing in here? It doesnt matter how popular a coin is or how popular its algorithm is. The only thing that should matter is, if the technology is interesting or not. The thing you just did is like kicking those who do ACTUAL development of any kind right in the balls.

If you want it to be like that, let it be, but I can tell you, that the community will turn their heads away from people like you.

Good day.

Spudz76 commented 5 years ago

xmr-stak has had a minimum hashrate policy before bothering to add new currencies, since forever. Sometimes the number changes but you were given the current expectation above. Take it more as a goal, and less as a bouncer bullying you.

Nobody has time to bandwagon on coins that most likely will be worthless, or introduce bugs into existing logic just to support a coin that ends up mostly vaporware. Also donation would not work as there is no "club accountant" to track 80 currency wallets and exchanges and whatever (new coins can't be converted for quite a while / if ever... another huge problem)

Unless of course you have time to add it yourself and submit a proper PR. Especially since it's so easy (apparently). However we also do not clean up code, as then we might as well just write it, so it must match formatting and style as already exists in the file - ready to publish or as close as possible.

On occasion oddball small coins got added, but because their creators submitted their own patches (aka did all the work to support their own currency). Many do it the wrong way and fork a miner while breaking the upstream linkage and then hack it (usually badly) to support their bad idea, so even if someone had spare time to merge code they broke the linkage so diffing is much, much, much more difficult. Also a code license violation... in most cases

However all bugs introduced by something are the responsibility of whomever authored the garbage code, including forks and any other updates or fixes. Many times that part is where the ball gets dropped. Which defers maintenance to core devs with scarce spare time. If you think people get mad for refusing to add a currency, imagine when we drop a currency later on because nobody wants to keep it updated and working well.

ClashLuke commented 5 years ago

Okay, I'm very sorry for my very harsh response previously, I think I misunderstood something. What I'm taking out of this discussion is, if we are able to implement an algorithm into the xmr-stak code without violating the licenses, causing harm for the rest of the code or just implementing a bugfilled, you will probably accept the pull request?

psychocrypt commented 5 years ago

We have currently 11 algorithms to maintain. There are many more available with very small changes and some are only used by a few users. To keep the quallity of the miner high and guve use time to work on important parts there is a the requirement of a minimal hash rate. But xmr-stak is ioen source. This give also small new coins the possibility to have a fast miner with a aceptable amount of work for the coin developer. This also mean if you create a coin and you are not able to provide a new or derived miner your dev skill is not enough to start nee currency.

Spudz76 commented 5 years ago

Yes please do, add your own mods for whatever coin, that's how open source works? You just can't redistribute the modified code, or compiled binaries from such, you have to submit PR if you want to share with others. Private use do whatever you want.

psychocrypt commented 5 years ago

He can dork xmr-stak and add his changes. The only requirement is that he keeps the change puplic visible in his branch. A pull request is not required