search

firemodels / fds

Fire Dynamics Simulator
https://pages.nist.gov/fds-smv/
Other
673 stars 627 forks source link

vent overlap warning messages #13665

Closed gforney closed 4 weeks ago

gforney commented 4 weeks ago

starting with this commit

Date: Wed Oct 30 14:50:49 2024 -0400 FDS Source: firemodels/smv#2085. Add flags to indicate OBST face hidden

I'm getting vent overlap warning for this case

smv/Verification/Visualization/vcirctest2.fds

I was not getting warning messages before this commit. The overlaps are real. The case has an open vent and also a circular vent on each of the 6 exterior walls. A side question, is there a better way to setup the case.

mcgratta commented 4 weeks ago

Ah, this is feature, not a bug. When I made the change to print extra information to the smv file about OBST faces, I had to move the location of the call statement for the subroutine that writes the smv file. Since this case is a "setup only", in the past, we would have never reached that part of the code that would print these warnings. Now we do. Good news is that these warnings are good to see if you were doing a setup check.

gforney commented 4 weeks ago

do you have any suggestions on how I could set up this case to avoid warnings ie to put a circular vent on an external boundary?

mcgratta commented 4 weeks ago

Did you change the order of the VENT lines?

gforney commented 4 weeks ago

yes. vent 12 cells are rejected again but this time the rejected cells are for the circular vent (since they appear last). looks like the first vent that occurs has priority.

On Thu, Oct 31, 2024 at 4:06 PM Kevin McGrattan @.***> wrote:

Did you change the order of the VENT lines?

— Reply to this email directly, view it on GitHub https://github.com/firemodels/fds/issues/13665#issuecomment-2450722322, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC6UCRWDRBW5KXZI6RYK2DLZ6KEV3AVCNFSM6AAAAABQ6SF27CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJQG4ZDEMZSGI . You are receiving this because you authored the thread.Message ID: @.***>

-- Glenn Forney