search

firemodels / fds

Fire Dynamics Simulator
https://pages.nist.gov/fds-smv/
Other
673 stars 627 forks source link

FDS Build: set clean-fds to true for clean-hypre and clean-sundials #13690

Closed cxp484 closed 3 weeks ago

cxp484 commented 3 weeks ago

@gforney, I wanted to mean that we should clean fds obj and mod files if --clean-hypre and --clean-sundials are specified. I did it for the linux part. Could you please do it for the Windows one.

gforney commented 3 weeks ago

already done. the fds build files are removed/cleaned if either the hypre or sundials library are built for any reason not just if the --clean-hpre or --clean-sundials options are specified

On Mon, Nov 4, 2024 at 2:11 PM Chandan Paul @.***> wrote:

@gforney https://github.com/gforney, I wanted to mean that we should clean fds obj and mod files if --clean-hypre and --clean-sundials are specified. I did it for the linux part. Could you please do it for the Windows one.

You can view, comment on, or merge this pull request online at:

https://github.com/firemodels/fds/pull/13690 Commit Summary

File Changes

(1 file https://github.com/firemodels/fds/pull/13690/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/firemodels/fds/pull/13690, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC6UCRTE72ZNCR5YCQT3M4TZ662ERAVCNFSM6AAAAABRE5SPS6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGYZTGNRSGQ4TCMI . You are receiving this because you were mentioned.Message ID: @.***>

-- Glenn Forney

gforney commented 3 weeks ago

let me know if you see something different

cxp484 commented 3 weeks ago

@gforney Great, I just tested the Windows version, and it's working as you described. I see that you're removing FDS files within both build_hypre.bat and build_sundials.bat, so the Windows version looks good. Thanks! :)