firemodels / fds

Fire Dynamics Simulator
https://pages.nist.gov/fds-smv/
Other
673 stars 627 forks source link

GitHub Actions fails due to change in Intel compiler #13715

Closed mcgratta closed 3 weeks ago

mcgratta commented 3 weeks ago

I pushed a minor FDS source code change to GitHub, and I received an error from GitHub Actions complaining that ifort is not recognized. I suspect that the latest oneAPI package has been installed, and the Intel "classic" Fortran compiler (ifort) is no longer recognized. Can we use an earlier version?

rmcdermo commented 3 weeks ago

I'll try to fix

marcfehling commented 3 weeks ago

The github-action setup-onapi has been updated to release 2025.0, but it can't find ifort anymore. ~This is not a problem of FDS, but of the github-action.~

~I am in touch with the developer of the github-action to get it resolved. I'll let you know once we find a solution. Feel free to ignore the failing CI for now.~

(EDIT: ifort has been discontinued, see below.)

marcfehling commented 3 weeks ago

I just saw that you updated from ifort to ifx. Has this solved the problem for you?

For the Intel MPI wrappers, you can either:

marcfehling commented 3 weeks ago

FYI, ifort has been discontinued in October 2024. We need to switch to ifx for the 2025.0 and future releases. https://www.intel.com/content/www/us/en/docs/fortran-compiler/get-started-guide/2025-0/overview.html

Alternatively, if you want to continue running the CI on ifort for now, we can specify an older release that still features ifort.

mcgratta commented 3 weeks ago

Yes, we fixed the problem. We now compile with mpiifx in GitHub actions, but we can still use the older compiler for our own use.