search

firetools / qgis2fds

An open source and free tool to export terrain elevation, landuse, and georeferencing to NIST FDS for computational fluid dynamics (CFD) wildfire or atmospheric pollutants dispersion simulations.
GNU General Public License v3.0
17 stars 13 forks source link

Mesh alignment issue #57

Closed johodges closed 1 year ago

johodges commented 1 year ago

Master has a minor mesh alignment issue. The mesh XB used in calculation of DX and DY for MULT is not rounded in that calculation but is rounded when exported to an FDS file. This sometimes leads to a misalignment of the mesh. See the local case in the attached example. Fixed in https://github.com/johodges/qgis2fds/tree/develop in 36113cb301ded57d2105ced407ece32c0f619a3e Las_Conchas_Fire.zip

rmcdermo commented 1 year ago

@johodges Thanks. Sorry, I was out yesterday. I will review today.

rmcdermo commented 1 year ago

@johodges do you have a branch that just fixes the mesh issue? If so, I can test and we are merge that to master.

Kevin and I talked and we need to get qgis2fds functional before the next FDS release can take place. Thanks

johodges commented 1 year ago

The current develop branch has the fix for the mesh and the additional algorithm for downloading the wcs server. No other changes beyond what was in develop before.

rmcdermo commented 1 year ago

So, is this ready for PR? As we discussed, we should work in atomic changes. Fixing that mesh boundary issue is a good fix that we could merge to the main branch asap.

johodges commented 1 year ago

Unfortunately my develop branch has the other changes that we wanted to break up into multiple PRs. I will set up my master_rebase branch with the minimum changes to get a PR in for Ema to review when he is back next week.

johodges commented 1 year ago

Fixed in dev branch in f2ef0c0.