search

firoorg / firo

The privacy-focused cryptocurrency
https://firo.org
MIT License
721 stars 354 forks source link

Ban nodes with version lower than 0.14.9.0 #1108

Closed justanwar closed 2 years ago

justanwar commented 2 years ago

PR intention

Ban versions of Firo client below 0.14.9.0.

Occasionally nodes on mainnet will connect to an older stuck version. If this older version is the first in the peer list, it takes a significant amount of time for it to disconnect and normal sync to continue.

On testnet, peers as low as version 0.14.1, 0.14.6 and 0.14.8 has been observed. As the number of testnet nodes are lower than mainnet, this problem is amplified.

Code changes brief

As per #742. Increase minimum version to 140900 as this is the minimum version required to run on the network currently.

lgtm-com[bot] commented 2 years ago

This pull request fixes 3 alerts when merging 5ae139691442d5ee5aa73c084e2cb787cc092ce0 into 738308bfcb1304adb28bfd78b8db9a7e890c47d5 - view on LGTM.com

fixed alerts: