Exclusively use depends mechanism to build firo - Githubissues

firoorg / firo

The privacy-focused cryptocurrency

https://firo.org

MIT License

721 stars 354 forks source link

Exclusively use depends mechanism to build firo #1138

Closed psolstice closed 2 years ago

psolstice commented 2 years ago

PR intention

Moved some of dependencies to depends (tor, bls-dash and relic). Effectively this prevents one from building firo the "old way" without building depends first.

Code changes brief

Build scripts and docs updated

lgtm-com[bot] commented 2 years ago

This pull request fixes 7 alerts when merging 456a2fb55476fe88ee1a13a5434971288fce0346 into a533ec51a9f7d5fd6afdf801a7fd92580426e1a1 - view on LGTM.com

fixed alerts:

4 for Incomplete ordering
2 for Except block handles 'BaseException'
1 for First parameter of a method is not named 'self'

lgtm-com[bot] commented 2 years ago

This pull request fixes 7 alerts when merging 3503e396625589a5a8c0e96d10628691aa1814c2 into a533ec51a9f7d5fd6afdf801a7fd92580426e1a1 - view on LGTM.com

fixed alerts:

4 for Incomplete ordering
2 for Except block handles 'BaseException'
1 for First parameter of a method is not named 'self'

lgtm-com[bot] commented 2 years ago

This pull request fixes 7 alerts when merging 0bc06c973c718e3718eb16b22ae47147512e0ad6 into a533ec51a9f7d5fd6afdf801a7fd92580426e1a1 - view on LGTM.com

fixed alerts:

4 for Incomplete ordering
2 for Except block handles 'BaseException'
1 for First parameter of a method is not named 'self'

lgtm-com[bot] commented 2 years ago

This pull request fixes 7 alerts when merging 8f496e3725ae628dab7ce67f992c586dee510a8f into a533ec51a9f7d5fd6afdf801a7fd92580426e1a1 - view on LGTM.com

fixed alerts:

4 for Incomplete ordering
2 for Except block handles 'BaseException'
1 for First parameter of a method is not named 'self'

lgtm-com[bot] commented 2 years ago

This pull request fixes 7 alerts when merging 094933a2976cf8265ef0d92ef7f8fcae06afdc07 into a533ec51a9f7d5fd6afdf801a7fd92580426e1a1 - view on LGTM.com

fixed alerts:

4 for Incomplete ordering
2 for Except block handles 'BaseException'
1 for First parameter of a method is not named 'self'

lgtm-com[bot] commented 2 years ago

This pull request fixes 7 alerts when merging de903359763352751420babd73b96b2ee9392d51 into a533ec51a9f7d5fd6afdf801a7fd92580426e1a1 - view on LGTM.com

fixed alerts:

4 for Incomplete ordering
2 for Except block handles 'BaseException'
1 for First parameter of a method is not named 'self'

AaronFeickert commented 2 years ago

The depends build succeeds on fresh VMs running Ubuntu 18.04.6 LTS and 20.04.3 LTS. It fails on VMs running Ubuntu 14.04.6 LTS and 16.04.7 LTS.

AaronFeickert commented 2 years ago

Command-line guix binaries produced from this branch run successfully on the following Ubuntu releases:

Ubuntu 14.04.6 LTS
Ubuntu 16.04.7 LTS
Ubuntu 18.04.6 LTS
Ubuntu 20.04.3 LTS

The GUI guix binary produced from this branch runs successfully on these Ubuntu releases:

Ubuntu 16.04.7 LTS
Ubuntu 18.04.6 LTS
Ubuntu 20.04.3 LTS

levonpetrosyan93 commented 2 years ago

Tested on

Ubuntu 18.04.6 LTS
Ubuntu 20.04.3 LTS
macOS Big Sur version 11.4 (intel)