firstdarkdev / modpublisher

A dual publishing Gradle Plugin to publish mods to Modrinth, Curseforge and GitHub in one go
MIT License
19 stars 3 forks source link

[BUG] `github.createTag` is inverted #14

Closed MattSturgeon closed 7 months ago

MattSturgeon commented 8 months ago

Currently, the check is performed before creating a new release, and only if createTag = false. However the logic is inverted and creating will fail if the tag does exist.

Also

I'm wondering how this should interact with github.draft. Theoretically, it shouldn't matter whether the tag exists when creating a draft, because releases don't create a git tag until they get "published" (draft=false).