firstdraft / dev_toolbar

MIT License
1 stars 0 forks source link

Full rewrite #1

Closed bpurinton closed 1 month ago

bpurinton commented 1 month ago

Related to #2

Given the scale of this re-write, I elected to create a new fresh bundle gem dev_toolbar repository as a first step and replace the old repo (https://github.com/firstdraft/dev_toolbar-v1) with this one.

On this PR, I've rewritten the entire gem. The instructions to install and test the gem in a Rails app are in the README, so follow along there.

To test I recommend: Generate a new app from https://github.com/appdev-projects/rails-7-template, then scaffold some tables and then following the steps in the README for setup of the Gem.

The CSS is still not great looking, and I'm not 100% sure of my solution via middleware. But it seems to work, and I think improvements (listed on this open issue: https://github.com/firstdraft/dev_toolbar/issues/2) can be made on additional smaller PRs once this is merged.

After merging this, I suppose I should get this gem up on RubyGems. I note that is already there (https://rubygems.org/gems/dev_toolbar) but connected with the old version on the other repository.. I'm not sure how to handle this and if maybe I should have just opened this PR into that older repo.

Full disclosure; I wrote this gem with a bunch of help from GP-TA (see my thread). The AI led me down some bad paths along the way and I had to do a lot of back-and-forth to arrive at what it looks like now.


:rocket: This description was created by Ellipsis for commit ef134f74bf561a98b07b79a96d28d027b0966d76

Summary:

This PR introduces a complete rewrite of the dev_toolbar gem, adding significant functionality and integration features for Rails applications.

Key points:


Generated with :heart: by ellipsis.dev


:rocket: This description was created by Ellipsis for commit 82cdcc36ca1c215da050ab31653f6b3d5ecc7966

Summary:

This PR introduces a complete rewrite of the dev_toolbar gem, focusing on a new middleware component that injects a customizable development toolbar into HTML responses in Rails applications, along with other significant updates.

Key points:


Generated with :heart: by ellipsis.dev

bpurinton commented 1 month ago

The instructions from the README appear to work so I don't see any issues with your approach. Are there notes somewhere about what the requirements for this rewrite are?

@jelaniwoods, see the issue board on this repo. I think I'm tracking any additional features we want to add, but if you see any issues / wishlist features that are completely impossible with this approach then let me know.. probably hard to tell at this point, so we can cross those bridges when we reach them and merge this as is then work on the smaller bits.