Replace undefined with null as default for index for BufferGeometry

firtoz / react-three-renderer

Render into a three.js canvas using React.

https://toxicfork.github.com/react-three-renderer-example/

MIT License

1.49k stars 155 forks source link

Replace undefined with null as default for index for BufferGeometry #208

Closed johnmarinelli closed 6 years ago

johnmarinelli commented 6 years ago

THREE.js uses an explicit type check for index as null in BufferGeometry. If it's null, it'll use a default setting. However, undefined throws an error.

toxicFork commented 6 years ago

Good catch, thank you for the PR :D