fishfolk / jumpy

Tactical 2D shooter in fishy pixels style. Made with Rust-lang 🦀 and Bevy 🪶
https://fishfolk.org/games/jumpy/
Other
1.67k stars 123 forks source link

Online lobby goes to map select once local player is ready, before all players are ready #1036

Closed MaxCWhitehead closed 2 weeks ago

MaxCWhitehead commented 1 month ago

Description

When starting an online match, one your player is readied up (but not remote player), it seems it goes to map select before all players are ready.

I am unsure if this is a bug I introduced with https://github.com/fishfolk/jumpy/pull/1032 or not. It is also possible it is an issue with bones matchmaker changes, but probably an issue in Jumpy, should inspect that first.

To Reproduce

  1. Start online match with two players
  2. Press ready on either one (but only client)
  3. Observe this client is now on map select, and second is still on player select.

(From this point selecting a map / proceeding may cause a crash due to network asset cid mismatch).

If these steps don't repro, it's possible it needs to be done more than once. (Though if we find this is the case, that may indicate this is impacted by some bones matchmaker state and not just jumpy usage of it).

Expected Behavior

Should not advance to map select until all players are ready.

Additional Context

No response

Log Messages

No response