fishjam-dev / fishjam

General purpose media server. Supports WebRTC, HLS, RTSP, SIP
https://fishjam-dev.github.io/fishjam-docs/
Apache License 2.0
197 stars 10 forks source link

[RTC-456] Add peerless room purge #150

Closed sgfn closed 6 months ago

sgfn commented 6 months ago

Acknowledging the stipulations set forth:

codecov[bot] commented 6 months ago

Codecov Report

Merging #150 (fcc81f0) into main (6b61fc4) will decrease coverage by 0.04%. The diff coverage is 92.59%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #150 +/- ## ========================================== - Coverage 86.87% 86.84% -0.04% ========================================== Files 64 64 Lines 1227 1247 +20 ========================================== + Hits 1066 1083 +17 - Misses 161 164 +3 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [lib/jellyfish/component/file.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9jb21wb25lbnQvZmlsZS5leA==) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish/room/config.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tL2NvbmZpZy5leA==) | `96.15% <100.00%> (+0.69%)` | :arrow_up: | | [lib/jellyfish\_web/api\_spec/room.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvYXBpX3NwZWMvcm9vbS5leA==) | `100.00% <ø> (ø)` | | | [lib/jellyfish\_web/controllers/room\_controller.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaF93ZWIvY29udHJvbGxlcnMvcm9vbV9jb250cm9sbGVyLmV4) | `100.00% <100.00%> (ø)` | | | [test/support/webhook\_plug.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-dGVzdC9zdXBwb3J0L3dlYmhvb2tfcGx1Zy5leA==) | `100.00% <100.00%> (ø)` | | | [lib/jellyfish/room.ex](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-bGliL2plbGx5ZmlzaC9yb29tLmV4) | `80.67% <86.66%> (-0.22%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [6b61fc4...fcc81f0](https://app.codecov.io/gh/jellyfish-dev/jellyfish/pull/150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).
sgfn commented 6 months ago

Bumped Elixir to 1.15 because we use Map.intersect which was added in that version

EDIT: disregard, restored 1.14 because test_load_balancing uses 1.14. Removed calls to Map.intersect instead