search

fission-codes / fission-cli

Rewrite it in Rust 🦀
Apache License 2.0
1 stars 1 forks source link

bls12_381_plus Dependency duplication #21

Open pinkforest opened 1 year ago

pinkforest commented 1 year ago

did-key at ^0.2.0 has bumped bls12_381_plus to ^0.7

signature_bls current is v0.35.0 which only brings bls12_381_plus at ^0.5

Need to raise with signature_bls (last 7 months ago) upstream to bump it and then ask bump at did-key on signature_bls

warning[B004]: found 2 duplicate entries for crate 'bls12_381_plus'
   ┌─ /home/foobar/pp/fission-cli/Cargo.lock:16:1
   │  
16 │ ╭ bls12_381_plus 0.5.2 registry+https://github.com/rust-lang/crates.io-index
17 │ │ bls12_381_plus 0.6.0 registry+https://github.com/rust-lang/crates.io-index
   │ ╰──────────────────────────────────────────────────────────────────────────^ lock entries
   │  
   = bls12_381_plus v0.5.2
     └── signature_bls v0.30.0
         └── did-key v0.1.1
             └── fission v0.1.0
   = bls12_381_plus v0.6.0
     └── did-key v0.1.1
         └── fission v0.1.0
pinkforest commented 1 year ago

Ok looks like ockam has re-organised this stuff - crate repository points here: https://github.com/build-trust/ockam/tree/develop/implementations/rust/ockam/signature_bls

But this gives: The 'build-trust/ockam' repository doesn't contain the 'implementations/rust/ockam/signature_bls' path in 'develop'.

I suspect the crate name has changed too... let's see at https://github.com/build-trust/ockam/tree/develop/implementations/rust/ockam

pinkforest commented 1 year ago

Raised at upstream: https://github.com/build-trust/ockam/issues/3864 to locate the new crate / repo.

Might need to change a crate around on this to migrate off from signature_bls at did-key

It seems that ockam has dropped off bls support: https://github.com/build-trust/ockam/issues/3864#issuecomment-1327985806

Raising issue at did-key upstream to figure out at: https://github.com/decentralized-identity/did-key.rs/issues/38 couse of action.

mrinalwadhwa commented 1 year ago

Hi 👋 from the Ockam team. We're not using bls anymore and didn't realize did:key was using it directly :worried:. If someone would like to maintain it, we'd be happy to help get that started in whatever way we can.

pinkforest commented 1 year ago

Thanks - I've circled back at upstream: https://github.com/decentralized-identity/did-key.rs/issues/38#issuecomment-1327989962