search

fitzchivalrik / gentletouch

A Final Fantasy XIV Quicklauncher (XIVLauncher) plugin. Allows one to create vibration patterns for the controller and specify triggers for them.
GNU Affero General Public License v3.0
4 stars 3 forks source link

Update for Patch 6.1 (API 6 and KeyNotFoundException Fix) #5

Closed ryankhart closed 2 years ago

ryankhart commented 2 years ago

I can see now why it this plugin didn't get updated for Patch 6.1. It took me quite a while to track down the new signature needed that no longer worked. I ended up finding it by tracking which end user tweaks in Simple Tweaks used an "ActionManager" that existed in the 'main' branch, and then using Visual Studio, ctrl+click to find where the ActionManager was being defined, and it turns out that Caraxi switched to using an external structs library (as you can see in the comment in my commit).

After I changed the signature and updated to API 6, I built it and it seems to be working for me in game right now.

I haven't fully tested everything yet, but I think it's good enough to be published a testing version.

fitzchivalrik commented 2 years ago

Thank you very much for the PR, but I am very, very sorry to tell you that I already updated GentleTouch to 6.1. I wanted to 'fix' the current handling of cooldowns with charges before releasing a new version, but did not finish it yet. In hindsight, I shoulda first released a version for 6.1 without any functional changes.

I am sorry for not pushing my changes proper and with that making you go through all the hassle of finding the new sig. Thank you for using the plugin and I hope you can see it as a fun learning experience or such x).

I will take time this weekend and either think of a better way to handle charges or at least release a version for 6.1 without functional changes.

ryankhart commented 2 years ago

Well, I learned a lot out of it anyway. And for anyone else who comes and visits who's motivated enough, I've left detailed instructions on #4 for how to build their own plugin with no experience. I'm sure it'll help someone. For now, I'm just glad I have it now to explore Shadowbringers for finding the aether currents, which I've just now reached.