search

fivetran / dbt_apple_store

Fivetran's Apple App Store source dbt package
https://fivetran.github.io/dbt_apple_store/
Apache License 2.0
0 stars 2 forks source link

Dev/modeling pt2 #2

Closed fivetran-sheringuyen closed 2 years ago

fivetran-joemarkiewicz commented 2 years ago

One last note is that I saw fivetran_utils was commented out of the source package. Was there a reason for this?

fivetran-sheringuyen commented 2 years ago

Thanks for the PR review @fivetran-joemarkiewicz! How absolutely embarrassing -- it looks like I had committed all my changes to the source package but unfortunately forgot to actually push the changes. So I went through and resolved all of the review comments that should be solved now. Big giant 🤦‍♀️ and my apologies for causing you the trouble.

However, the two big questions you had seemed to be around the below:

  1. Downloads configurability - I've scratched that from the package as downloads should be an integral part of customer reporting and should encourage customers to enable this model if they haven't already. But this brings up another great point, and I'm going to double check all the subscriptions tables and make sure that they are properly configured as well!
  2. I had originally commented out Fivetran Utils in the source package because of the problem around accessing redshift for the get columns for macros (Jamie put in a fix that I was using!). I'll actually go update that now.
fivetran-sheringuyen commented 2 years ago

Thanks for the PR review @fivetran-joemarkiewicz! How absolutely embarrassing -- it looks like I had committed all my changes to the source package but unfortunately forgot to actually push the changes. So I went through and resolved all of the review comments that should be solved now. Big giant 🤦‍♀️ and my apologies for causing you the trouble.

However, the two big questions you had seemed to be around the below:

  1. Downloads configurability - I've scratched that from the package as downloads should be an integral part of customer reporting and should encourage customers to enable these tables if they haven't already. But this brings up another great point, and I'm going to double check all the subscriptions tables and make sure that they are properly configured as well!
  2. I had originally commented out Fivetran Utils in the source package because of the problem around accessing redshift for the get columns for macros (Jamie put in a fix that I was using!). I'll actually go update that now.