fivetran / dbt_xero

Data models for Fivetran's Xero connector built using dbt.
https://fivetran.github.io/dbt_xero/#!/overview
Apache License 2.0
10 stars 21 forks source link

Hotfix/variable/bank transactions #27

Closed sjmunoz closed 2 years ago

sjmunoz commented 2 years ago

Pull Request Are you a current Fivetran customer? Santiago Muñoz, Software Engineer, Aleph Labs

What change(s) does this PR introduce? This PR introduces the xero__using_bank_transaction variable to disable the bank_transaction models if a user does not have them in their source.

This PR requires this change on the dbt_xero_source

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood 🚀

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

sjmunoz commented 2 years ago

@fivetran-joemarkiewicz Thank you for the review and help!

fivetran-joemarkiewicz commented 2 years ago

The source package is live and we can go ahead and merge this!