fivetran / dbt_xero

Data models for Fivetran's Xero connector built using dbt.
https://fivetran.github.io/dbt_xero/#!/overview
Apache License 2.0
10 stars 21 forks source link

Fix net_amount duplication in balance sheet report #30

Closed danieltaft closed 2 years ago

danieltaft commented 2 years ago

…by including source_relation in cross join.

Now the net_amount shouldn't duplicate when mutliple xero sources are used.

Pull Request Are you a current Fivetran customer?

Daniel Taft, founder dashlytix

What change(s) does this PR introduce? Bug fix

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

I re-ran the balance sheet report with these changes on a dbt project with multiple companies and the package compiles and now the net amount variable is no longer duplicating.

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

:grin: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.