Code review request: New menu icons

[GoogleCodeExporter]

Mercurial clone with changes to be reviewed:

http://code.google.com/r/mariansteinbach-mytracks

Revisions to be pulled from that clone (or "all"):

http://code.google.com/r/mariansteinbach-mytracks/source/detail?r=53162eb22e142a
66248beeb6747262e78308fd01

Purpose of changes on the clone:

- Directory structure for multi-resolution drawables (hdpi, mdpi, ldpi).
- menu icons in all resolutions

There are no code changes.

Original issue reported on code.google.com by marian.s...@gmail.com on 2 Jan 2011 at 10:09

[GoogleCodeExporter]

I don't think you turned comments on for your clone.

I really don't like the start recording icon.  I see it as the red cross.  
Please just do a simple circle.
Same goes for the stop.  Please just do a simple square.
I'm not sure if we use the stats menu icon anywhere.  I think we should remove 
it.

Original comment by sandordo...@google.com on 3 Jan 2011 at 4:09

[GoogleCodeExporter]

I can't see how to enable comments. Reviews are enabled...

I might do you the favor of changing the stop/record icons. You could return 
the favor by raplaceing "Tracks list", "Waypoints" and "Last Segment". How's 
that? ;-)

Original comment by marian.s...@gmail.com on 3 Jan 2011 at 5:30

[GoogleCodeExporter]

Good call on the start/stop icons. Keep up the good work!

Original comment by thomgk...@gmail.com on 3 Jan 2011 at 9:36

[GoogleCodeExporter]

Marian I am not sure I understand your comment.  We all work together on this.  
For the most part we don't do tit-for-tat trades.  We work to come to a 
consensus on contentious issues.  We talk offline and most of the other devs 
did not like your start and stop icons.

I like all of the other new icons.  I am not sure if that is what you are 
asking for.
On a related note.  I am assuming you are generating these icons using some 
other master photoshop or similar file.  Can you make sure to add that to your 
client somewhere?  I might make sense to add it as a new root level "images" 
directory.  That way if the standard changes we can easily regenerate the 
images.

Original comment by sandordo...@google.com on 4 Jan 2011 at 12:57

[GoogleCodeExporter]

Hi Sandor! Please don't take my comments too serious. I do this for fun, and 
you should see my comments with that in mind. Since you only commented on the 
icons which don't fit, I just wanted to have some reaction on the other icons 
as well.

Thanks for pointing me to "Allow non-members to review code". I activated it 
now.

As for adding the original assets to the repository: As I stated in a related 
thread before, that's definitely fine with me. We just didn't have a directory 
for that yet. 
http://developer.android.com/guide/practices/ui_guidelines/icon_design.html 
suggests to have a folder named "assets" on the same level as "res". If that's 
fine with you, I create that folder in my clone including all photoshop and 
Illustrator files so you cna pull them.

Regarding the "Start recording" icon: Before I create the icons, I just want to 
make sure that you are aware of the fact that the "red cross" is actually the 
standard Android icon for "Add item". See 
android-9/data/res/drawable-hdpi/ic_menu_add.png in the SDK. I figured that in 
this case it might make sense to use this icon since Android users are likely 
to know it from other apps as well. That's why I derived Stop and Pause from 
this shape, to make them appear similar enough. I'm saying this since I'm just 
not sure if you have considered it. I will definitely build the shape you ask 
for if that is what you want.

Original comment by marian.s...@gmail.com on 4 Jan 2011 at 7:57

[GoogleCodeExporter]

Just saw that the "assets" folder is there already. Will add the icons material 
there.

Original comment by marian.s...@gmail.com on 4 Jan 2011 at 8:00

[GoogleCodeExporter]

Original comment by sandordo...@google.com on 6 Jan 2011 at 11:53

• Added labels: Targeting-1-1

[GoogleCodeExporter]

Marian I would like to pull this change in for our next big release.  Could you 
fix the start and stop icons so I can pull this all in?

Original comment by sandordo...@google.com on 11 Jan 2011 at 4:20

[GoogleCodeExporter]

When would you like to pull it? I think I could make the icons late Wednesday 
(which would be early Wednesday your time).

Original comment by marian.s...@gmail.com on 11 Jan 2011 at 9:59

[GoogleCodeExporter]

I think we are trying to finish 1-1 by the end of the month.  So the end of the 
week should be fine.

Original comment by sandordo...@google.com on 11 Jan 2011 at 4:57

[GoogleCodeExporter]

I created the simplified versions for "Record Track" and "Stop Recording" and 
committed the files to this change:

Revision b650a8b8b9
https://code.google.com/r/mariansteinbach-mytracks/source/detail?r=b650a8b8b9aa6
2ebefd9a256ae275ad69901edab

As I understand it, the new Revision above has to be pulled after Revision 
3b3f671eec and Revision 53162eb22e. Right?

Revision 3b3f671eec
Pre-production files for menu icons (second attempt)
http://code.google.com/r/mariansteinbach-mytracks/source/detail?r=3b3f671eec2689
fc3791528513b42b9f4d59fe69

Revision 53162eb22e
All menu icons as PNG
http://code.google.com/r/mariansteinbach-mytracks/source/detail?r=53162eb22e142a
66248beeb6747262e78308fd01

Original comment by marian.s...@gmail.com on 12 Jan 2011 at 7:13

[GoogleCodeExporter]

Original comment by sandordo...@google.com on 14 Jan 2011 at 12:42

• Changed state: Fixed