search

fjoppe / Legivel

F# Yaml 1.2 parser
https://fjoppe.github.io/Legivel
The Unlicense
60 stars 5 forks source link

Could you please provide a netstandard compatible build #7

Closed pkese closed 5 years ago

pkese commented 5 years ago

Hi,

I'm getting the following when trying to install Legivel into a .net core project

warning NU1701: Package 'Legivel 0.2.1' was restored using '.NETFramework,Version=v4.6.1' 
instead of the project target framework '.NETCoreApp,Version=v2.1'.  
This package may not be fully compatible with your project.

Is there a reason why this project can't/hasn't been build for .net standard? It doesn't seem there are any specific dependencies specific to classical .net framework.

If not... may I kindly ask you to provide a netstandard compatible build on nuget.

Thanks

fjoppe commented 5 years ago

Hi,

A few months ago I tried to prepare this library for .Net Standard. My wish was to support multi-platform from the solution. I got stuck in running the unit-tests in multi-platform mode. Also, Fake was in the middle of a migration, so I decided to wait. But I never got around picking this up again. Help would certainly be appreciated. Regards, Frank

pkese commented 5 years ago

Yes, I share your experience - I too got bitten by Fake being a running target for a while. Is your multi-platform code in the Release_2.2.0 branch? I might give it a look if I find some time to spare...

fjoppe commented 5 years ago

The Release_2.2.0 branch is indeed the latest. I ust pushed some stuff in right now so that you can use the latest.

fjoppe commented 5 years ago

Currently working on a multi target build in this branch. The build works (on my machine), outputs net45 and netstandard2.0 framework versions. It even runs the unit tests per framework (this cost a lot of time to find out how). Meanwhile I've also made a few performance improvements (ongoing process).

Still two things are not working:

pkese commented 5 years ago

I'm just wondering: Is the net45 version still necessary if you can provide a netstandard compatible build? As far as I understand, netstandard compliant DLL can be used seamlessly in both netcore and net-framework style projects.

fjoppe commented 5 years ago

It would be ok to provide both. Maybe I'm doing something wrong. But my experience with linking .netstandard libararies into the FSI in Visual Studio has caused me quite some troubles. net45 libs were easier to reference. And my assesment for using a library is the observation whether the lib is "close" to the framework I'm using. So providing multi-platform helps build confidence, but that is self-projection. :)

Still working on this enhancement. Have not heard from FSDocumentation whether they will solve my issue, And in the meanwhile I'm implementing a new Regex algorithmn to improve performance.

fjoppe commented 5 years ago

Hi,

I have released a new version of this package Legivel 0.3.0 which includes a netstandard binary. Also did some work to make it faster, but not satisfied yet in the latter topic.

pkese commented 5 years ago

Thanks, Frank. You rock! It works beautifully.
I assume we can now close this ticket - performance is probably orthogonal to this issue, no?

fjoppe commented 5 years ago

Yes it can be closed.

Regards, Frank

Verstuurd vanaf mijn iPhone

Op 6 mei 2019 om 13:43 heeft Peter Keše notifications@github.com<mailto:notifications@github.com> het volgende geschreven:

Thanks, Frank. You rock! It works beautifully. I assume we can now close this ticket - performance is probably orthogonal to this issue, no?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/fjoppe/Legivel/issues/7#issuecomment-489591490, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACMMW5AHNTZ3HIADSCGP4IDPUAKV3ANCNFSM4GDCUQ4Q.