search

flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.73k stars 1.58k forks source link

Deletaion for active tool does not work #3228

Open KES777 opened 1 year ago

KES777 commented 1 year ago

Flameshot Version

Flameshot v11.0.0 (11.0.0-2 Debian) Compiled with Qt 5.15.2

Installation Type

Linux, MacOS, or Windows Package manager (apt, pacman, eopkg, choco, brew, ...)

Operating System type and version

Linux Mint v21.1 Cinnamon

Description

I tried to

image

Steps to reproduce

  1. run flameshot gui
  2. Select tool c
  3. Try to delete current tool Del

If you press Esc it deselects current tool though.

Screenshots or screen recordings

dd

System Information

Linux Mint v21.1 Cinnamon

System: Host: kes-X406UA Kernel: 5.15.0-73-generic x86_64 bits: 64 Desktop: Cinnamon 5.6.8 Distro: Linux Mint 21.1 Vera Graphics: Device-1: Intel HD Graphics 620 driver: i915 v: kernel Device-2: IMC Networks USB2.0 HD UVC WebCam type: USB driver: uvcvideo Display: x11 server: X.Org v: 1.21.1.4 driver: X: loaded: modesetting unloaded: fbdev,vesa gpu: i915 resolution: 1920x1080~60Hz OpenGL: renderer: Mesa Intel HD Graphics 620 (KBL GT2) v: 4.6 Mesa 22.2.5

mmahmoudian commented 1 year ago

I think we have used a bad word here. By "delete current tool" what we mean is "delete the selected object". This is used in the following scenario:

  1. open flameshot gui
  2. select a tool (e.g arrow by pressing a)
  3. draw something
  4. deselect the tool (e.g by clicking on the tool again, or pressing Esc or pressing a)
  5. select what you have draw (a dotted rectangle appears around the object)
  6. press Del

I change this to Enhancement rather than a bug. Also please feel free to suggest alternative text.

KES777 commented 1 year ago

@mmahmoudian oh... I used Flameshot couple of years, but never know that I can delete what I draw not by CTRL+z undo it! Why help message was not displayed for tools too??

Ok. Thank you for this tip! It seems would be useful to have "hand" tool. So people could see it and understand that it is possible to select something when none other tools were selected. eg. when deselecting current tool - activate "hand" tool by default.

  1. Implement "hand" tool

  2. For backward compatibility "Show 'hand' tool" option could be implemented (enabled by default). So old users could disable it.

  3. My proposition for name is: Delete selected drawn object

KES777 commented 1 year ago
  1. Probably here should be implemented also Unselect current active tool hotkey option.
mmahmoudian commented 1 year ago
  1. Probably here should be implemented also Unselect current active tool hotkey option.

As I mentioned in my 4th point, Esc deselect the active tool.

KES777 commented 1 year ago

Yes, and for this action there is not shortcut. image

Which I propose to implement.

mmahmoudian commented 1 year ago

Yes, and for this action there is not shortcut.

The Esc is the shortcut, but it is not customizable, and that is by design. The only key that we reserved our rights to keep it as is and do not allow user to change it. This is because users do all sorts of weird things with their config, and we need to have a universal and uniform way to instruct them to cancel things without asking them their config.

mmahmoudian commented 1 year ago

Shall we close this issue? For hand tool please open a feature request and copy paste your comment about it. (And modify it if you want).

mmahmoudian commented 1 year ago

I just realized the name change should be done before closing the issue. I checked and it can be straightforward thing but the translations would make it complicated for me to change. I would rather wait for other devs to do it or suggest the best way so I can do it myself.

This is what should be done: Delete current tool -> Delete selected drawn object

Amangupta0000 commented 1 year ago

https://github.com/flameshot-org/flameshot/pull/3348#issue-1909996144 Changed the name.