search

flang-compiler / flang

Flang is a Fortran language front-end designed for integration with LLVM.
Other
806 stars 137 forks source link

Massive upheaval in libpgmath symbols after 2ffc9d6 #774

Open ibara opened 5 years ago

ibara commented 5 years ago

Hi --

Commit 2ffc9d6 created huge symbol changes in libpgmath.so (at least, on OpenBSD). Is this intentional? Attached below is a diff of symbols between pre- and post-commit.

This matters at least for OpenBSD, since it's relatively easy to get flang to emit fmth_i_amod and fmth_i_dmod symbols with the NIST F77 test suite.

Let me know what I can do to help.

pgmath-symbols.txt

d-parks commented 5 years ago

Can you please send me a build log from a serial make?

ibara commented 5 years ago

Sure. Attached. cmake version 3.10.2 pgmath-build.txt

d-parks commented 5 years ago

I don't have access to an OpenBSD system. I'm assuming that you're building on an x86_64 system. From the log you sent, it seems that libpgmath thinks it's being build for a generic processor where most of the missing symbols would not be referenced. Would you be so kind as to enable the debug "if(0)" @ line 120 of the top level CMakeList.txt file and send me the output of all the cmake variables? No need to do a full build - feel free to stop the process immediately after the dumping of the vars? Thank you.

ibara commented 5 years ago

Thank you! That was the hint I needed. Pull request #776 fixes the issue.