Setting DTM=0.3 for None cases

flaresimulations / synthesizer

Synthesizer - a code for creating synthetic astrophysical observables

https://flaresimulations.github.io/synthesizer/

GNU General Public License v3.0

17 stars 8 forks source link

Setting DTM=0.3 for None cases #638

Closed aswinpvijayan closed 3 months ago

aswinpvijayan commented 4 months ago

This https://github.com/flaresimulations/synthesizer/blob/main/src/synthesizer/particle/gas.py#L139 automatically sets DTM to 0.3 when the dust mass or DTM is not given. Logically there could be instances of where there are no gas particle in a galaxy (or when masked), that setting it automatically does not make sense. Would be best to check if for example the metallicity is None and keep the values as None.

christopherlovell commented 4 months ago

Agreed, feel free to raise a PR