[suspend][core] [1.x] fix: suspended users can remove avatar

imorland commented 5 months ago

Reported https://discuss.flarum.org/d/32899-flarum-v180-released/83 and following on from https://github.com/flarum/framework/pull/3890

Changes proposed in this pull request: Dispatch AvatarDeleting before beginning the avatar deletion process, add a listener to flarum/suspend to prevent a suspended user from removing their avatar. Admins and other users with permission may still remove the avatar of the suspended user if required.

New tests for this scenario are included. Happy to make the same change against the 2.x branch if required, please let me know.

Reviewers should focus on:

Screenshot

QA

Necessity

[X] Has the problem that is being solved here been clearly explained?
[X] If applicable, have various options for solving this problem been considered?
[X] For core PRs, does this need to be in core, or could it be in an extension?
[X] Are we willing to maintain this for years / potentially forever?

Confirmed

[X] Frontend changes: tested on a local Flarum installation.
[X] Backend changes: tests are green (run composer test).
[X] Core developer confirmed locally this works as intended.
[X] Tests have been added, or are not appropriate here.

imorland commented 5 months ago

Ugh, damn StyleCI. See https://github.com/flarum/framework/pull/3998/commits/f7c0a3b7e95c1fecae9c1fcfae39fedd0149c3b0 for my changes here.

imorland commented 5 months ago

I agree that what you're saying would make sense for 2.x, but I feel that if that was implemented in 1.x we run the risk of introducing a breaking change by adding a removeAvatar gate.

How would we feel about the change proposed here for 1.x as a "quick fix/patchup", and a solution based on a gate for 2.x?

flarum / framework

[suspend][core] [1.x] fix: suspended users can remove avatar #3998