Closed SychO9 closed 2 months ago
Why is the implementation of author different than the other related to users? I feel like their use should be identical or at least similar in such a way that instead of relying on users to know IDs, we use usernames.
That's how the filter was implemented prior to this. I think these user filters should all support username and ID, and in the UI default to use the username, in the future we will likely add something to allow hiding usernames which is why ID still matters.
will modify them as such.
updated
If this works, I'd say start merging everything in whenever it suits you and we'll start testing end-to-end when you give the sign.
💪 Excellent work, also from @iamdarkle. Really looks awesome.
Part of the 2.0 milestone
Changes proposed in this pull request:
Screenshot
Necessity
Confirmed
composer test
).Required changes: