Closed DavideIadeluca closed 1 month ago
@DavideIadeluca for 2.x you don't actually need to do anything 👍
In 2.x every module used by the code (core and extensions) is accessible by other extensions. Unless the module is declared but not used (which is not the case currently).
@DavideIadeluca for 2.x you don't actually need to do anything 👍
In 2.x every module used by the code (core and extensions) is accessible by other extensions. Unless the module is declared but not used (which is not the case currently).
@SychO9 Yeah I was also of the same understanding per the diary you shared on discuss. But I'm kind of confused now what the usage is for the newly added forum.ts
files in core and extensions?
@DavideIadeluca those are mostly the result of automatically converting the old compat files. A lot of the imports there are redundant and add nothing. However because we now lazy load certain components, those files serve as a way to ensure certain components are not lazy loaded, without having to constantly check where they are used.
We'll probably remove those (forum.ts, common.ts, admin.ts) files for the bundled extensions before 2.0 is out.
Fixes https://github.com/flarum/framework/pull/4006#issuecomment-2380559537
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot
QA
fireDebugWarning
)fireDeprecationWarning
)Necessity
Confirmed
composer test
).Required changes: