[1.x] [tags] feat: option to display tags in DiscussionsSearchSource

[imorland]

Changes proposed in this pull request: Introduces an option to display the tag label(s) above the discussion title in search results (DiscussionsSearchSource). Disabled by default to maintain current behaviour.

Reviewers should focus on: @flarum/core I feel this is something to also include in 2.x?

Screenshot Search:

Tags settings:

QA

Necessity

• [ ] Has the problem that is being solved here been clearly explained?
• [ ] If applicable, have various options for solving this problem been considered?
• [ ] For core PRs, does this need to be in core, or could it be in an extension?
• [ ] Are we willing to maintain this for years / potentially forever?

Confirmed

• [ ] Frontend changes: tested on a local Flarum installation.
• [ ] Backend changes: tests are green (run composer test).
• [ ] Core developer confirmed locally this works as intended.
• [ ] Tests have been added, or are not appropriate here.

Required changes:

• [ ] Related documentation PR: (Remove if irrelevant)
• [ ] Related core extension PRs: (Remove if irrelevant)

[SychO9]

Why not just make a custom extension? especially since this is not something that can be ported to 2.x as 2.x search UI is highly different and has tags by default

[imorland]

Why not just make a custom extension? especially since this is not something that can be ported to 2.x as 2.x search UI is highly different and has tags by default

Fair comment, I've not seen 2.x for some time, so didn't know about that!

Yes a custom extension can absolutely be created now that DiscussionsSearchSource and DiscussionsSearchItem can be extended. The feeling was to push this functionality back to the root so that it can potentially benefit the whole 1.x ecosystem :)

[SychO9]

imho, a custom extension released to the wider community is just as beneficial for those looking for such a feature.

[imorland]

imho, a custom extension released to the wider community is just as beneficial for those looking for such a feature.

Fair enough, I'm having issues with typings (again!) on this one anyway!. Will close this and consider a standalone extension :)