[1.x] chore: change private to protected, allowing extensibility - Githubissues

flarum / framework

Simple forum software for building great communities.

http://flarum.org/

6.39k stars 834 forks source link

[1.x] chore: change private to protected, allowing extensibility #4119

Closed imorland closed 4 days ago

imorland commented 4 days ago

Simply change private to protected so we can extend and replace ResponseFactory when required.

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Necessity

[ ] Has the problem that is being solved here been clearly explained?
[ ] If applicable, have various options for solving this problem been considered?
[ ] For core PRs, does this need to be in core, or could it be in an extension?
[ ] Are we willing to maintain this for years / potentially forever?

Confirmed

[ ] Frontend changes: tested on a local Flarum installation.
[ ] Backend changes: tests are green (run composer test).
[ ] Core developer confirmed locally this works as intended.
[ ] Tests have been added, or are not appropriate here.

Required changes:

[ ] Related documentation PR: (Remove if irrelevant)