.Dropdown--split class missing from .SubscriptionMenu. Not re-using the SplitDropdown component

[clarkwinkelmann]

Bug Report

Current Behavior

The subscription dropdown in the DiscussionPage-nav is not re-using the SplitDropdown component, but is manually composing its split dropdown. But it does not have the Dropdown--split class so it's not styled along with other split dropdowns when using that class.

Subscription dropdown classes:

Dropdown ButtonGroup SubscriptionMenu

Expected classes on a split dropdown:

ButtonGroup Dropdown dropdown Dropdown--split

Steps to Reproduce

Apply custom style. Silly example: make the split part of the dropdown orange:

.Dropdown--split > .Dropdown-toggle {
    background: orange;
}

The subscription menu will not be affected.

Expected Behavior The subscription split dropdown should have the .Dropdown--split class.

Environment

• Flarum version: beta 12

Possible Solution Add the class in https://github.com/flarum/subscriptions/blob/master/js/src/forum/components/SubscriptionMenu.js#L84

Or better, actually use the SplitDropdown component from core https://github.com/flarum/core/blob/afe06ea750cfd81767461a3884a92a26f0b0ce37/js/src/common/components/SplitDropdown.js

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

[clarkwinkelmann]

Still relevant. However it's not as simple as it initially appeared, see comment https://github.com/flarum/subscriptions/pull/27#issuecomment-636969043

The split dropdown has the default behavior of hiding the first child on desktop which we should ideally move to another dedicated classname as it's only useful for controls which are the main control of the page.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!