search

flashmob / go-guerrilla

Mini SMTP server written in golang
MIT License
2.79k stars 366 forks source link

dep #122

Closed athoune closed 5 years ago

athoune commented 6 years ago

Using dep, not glide.

athoune commented 6 years ago

Sorry for the battle with Travis.

flashmob commented 6 years ago

That's ok. Thanks for the contribution!

Will update to dep soon, your PR means it will be sooner 😀

On Sat., 13 Oct. 2018, 04:44 Mathieu Lecarme, notifications@github.com wrote:

Sorry for the battle with Travis.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/flashmob/go-guerrilla/pull/122#issuecomment-429441421, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnmP7oGB13HV_oZOh-F7ODRRwBox0flks5ukPEIgaJpZM4WjnTs .

jamestbrown commented 6 years ago

👍 👍

dvcrn commented 5 years ago

Luckily dep init is already capable converting a glide project over to dep so this hopefully should be pretty simple 👍

ThisIsAreku commented 5 years ago

Any news about this MR ?

flashmob commented 5 years ago

@ThisIsAreku Thanks for the reminder. Yes, it will be merged soon. For now, If you're using dep, you may try the dep init option for converting from glide as suggested above, or merge in this branch to your fork.

dvcrn commented 5 years ago

For now, If you're using dep, you may try the dep init option for converting from glide as suggested above

I’ve been doing this for my usecase without any issues

lord-alfred commented 5 years ago

@athoune, @flashmob Readme and https://github.com/flashmob/go-guerrilla/wiki/Build-Notes still contains text about glide

flashmob commented 5 years ago

Thanks! Updated.

On Fri, 2 Aug 2019 at 20:26, Lord Alfred notifications@github.com wrote:

@athoune https://github.com/athoune, @flashmob https://github.com/flashmob Readme and https://github.com/flashmob/go-guerrilla/wiki/Build-Notes already contains text about glide

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/flashmob/go-guerrilla/pull/122?email_source=notifications&email_token=AAE6MP47JP6PVZGPW3TXDNDQCQDTRA5CNFSM4FUOOTWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3NLQEA#issuecomment-517650448, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE6MP5OQZWODTYV4EYKKNLQCQDTRANCNFSM4FUOOTWA .

lord-alfred commented 5 years ago

But readme not updated :) https://github.com/flashmob/go-guerrilla#dependencies https://github.com/flashmob/go-guerrilla#1-import-the-guerrilla-package

flashmob commented 5 years ago

Thanks! Will update the readme soon (or you can beat me to it and submit a PR if you like!)

On Sat., 3 Aug. 2019, 04:08 Lord Alfred, notifications@github.com wrote:

But readme not updated :) https://github.com/flashmob/go-guerrilla#dependencies https://github.com/flashmob/go-guerrilla#1-import-the-guerrilla-package

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/flashmob/go-guerrilla/pull/122?email_source=notifications&email_token=AAE6MPZ4GWNKMMTSF62KSLDQCSA3TA5CNFSM4FUOOTWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OTENI#issuecomment-517812789, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE6MP2I7KWKTBRN4IN2E63QCSA3TANCNFSM4FUOOTWA .