flask-extensions / Flask-GoogleMaps

Easy way to add GoogleMaps to Flask applications. maintainer: @getcake
https://flask-googlemaps.com
MIT License
647 stars 196 forks source link

Google Map doesn't show up in example #142

Closed luskah closed 3 years ago

luskah commented 3 years ago

Hello, thanks for the work !

However, I can't even display the Google Maps in the example code. I already have a key for these Google Maps API so I added GoogleMaps(app, key = mykey) image

Here is a screen of what I get one I run the python file:

unnamed

Thank you if you can help me figuring out where is the problem

Herugrim commented 3 years ago

I upgraded to 0.4.1 and encountered the same issue on my site. An omitted comma causes the javascript to break, I already made PR #143 to fix it.

bhuveshsharma09 commented 3 years ago

Thank you @luskah for reporting the bug. Thanks, @Herugrim for resolving it already.

rohitabraham5 commented 3 years ago

Hello All, Any idea when will the changes be merged and pushed? Thanks in advance

anafdal commented 3 years ago

I am still having the same issue. Is there anything we can do?

ghost commented 3 years ago

The author is dead from COVID. It must be fixed manually.

bhuveshsharma09 commented 3 years ago

Hey Guys, Waiting for #144 to merge. That will resolve the issue.

Meanwhile, you can consider following the instruction given in #144 .

Herugrim commented 3 years ago

To be complete, PR #143 that fixes this bug was merged last week but no new release was done. In the meantime I made another PR #144 to iron out some extra things like loading unnecessary JavaScript. @bhuveshsharma09 could you please check out that PR? I asked for your input, if you can confirm that nothing breaks in the added functionality introduced in 0.4.1 then @Riverfount can merge #144 and create a new pip release.

In the meantime you can either add a comma manually as per #143 or install 0.4.0 manually: pip install -I flask-googlemaps==0.4.0

Riverfount commented 3 years ago

Hi guys I merged all the last PRs and create a new release of the extension. I hope that solves this issue.