search

flatcar / sysext-bakery

Recipes for baking systemd-sysext images
Apache License 2.0
72 stars 37 forks source link

Add a sysext for vim-huge #78

Open jsalatiel opened 5 months ago

jsalatiel commented 5 months ago

There are several cases when the user needs to edit k8s yamls inplace directly on the master nodes and having syntax highlighting and advanced formatting of vim available is a nice feature since the default vim of flatcar have those disabled.

chewi commented 5 months ago

We have just discussed whether we might want to leverage existing Gentoo packages for this instead. We could potentially do this in such a way that avoids dependence on system libraries (besides glibc) either by still statically linking or by placing the dynamic libraries within the sysext. I could look into this soon, but I don't mind accepting this in the interim.

jsalatiel commented 3 months ago

Hi @chewi , will this be accepted?

chewi commented 3 months ago

I have no objections, but I'd want someone else to look over it. I'm not familiar with sysext building yet.

pothos commented 3 months ago

FYI, the build process of the extensions in this repo is supposed to be fast, avoiding compilation if we can (that's the reason one build recipe was not included in the official repo releases so far). One can bundle existing distro binaries (e.g., from a Docker image) with one of these helper scripts: https://github.com/flatcar/sysext-bakery?tab=readme-ov-file#flix-and-flatwrap - for choosing one way and making it work one needs to know what paths vim relies on at runtime.

That said, I'm not reviewing things here now and someone else has to decide what to do with this PR.

xinity commented 2 months ago

IMHO sysext should not be considered as the next package manager, so perhaps vim as an editor that exists in every linux distribution might not fit here.

just sharing my point of view, no harm :)