flathub / io.github.cudatext.CudaText-Qt5

https://flathub.org/apps/details/io.github.cudatext.CudaText-Qt5
1 stars 1 forks source link

Is patch for Qt5-check-validity OK ? #46

Closed Alexey-T closed 10 months ago

Alexey-T commented 10 months ago

@JordanL2 I made the patch https://github.com/Alexey-T/CudaText/commit/efbcba60819d6f2849ec98108c0215281600ed5e to solve https://github.com/Alexey-T/CudaText/issues/5308

but I am unsure: what version of Lazarus + libQt5Pas do you use?

JordanL2 commented 10 months ago

Currently it's using Lazarus 3.0.

https://gitlab.com/freepascal.org/lazarus/lazarus/-/archive/lazarus_3_0/lazarus-lazarus_3_0.tar.gz

Which version of Lazarus should it be using now?

Alexey-T commented 10 months ago

Lazarus 3.0 is good.

what version of libQt5Pas? For Linux Qt5 version, library libQt5Pas is required, release 1.2.15 or newer. Get it from releases on this page.

JordanL2 commented 10 months ago

Sorry correction, I got myself confused.

libQt5Pas is being build from Lazarus 3.0 source. FPC and Lazarus are coming from this Flatpak SDK which uses:

  1. FPC 3.2.2
  2. Lazarus 2.2.6-0
Alexey-T commented 10 months ago

So my new patch makes CudaText not compilable on Lazarus 2.2. can you add local fix to your system:

procedure TfmMain._QtCheckLibValidity;
begin
  {$ifdef LCLQT5}
  QTimer_singleShot(10, @_QtDelayTimeOut);
  {$endif}
end;

here comment the code inside IfDef.

JordanL2 commented 10 months ago

I'll bring the Lazarus download/compilation logic into the Cudatext flatpak, so we have direct control over the Lazarus version, and update it to 3.0.0 before I do the next update release.

Alexey-T commented 10 months ago

Great..

JordanL2 commented 10 months ago

EDIT: Never mind, I was building an old version, all good...

JordanL2 commented 10 months ago

CudaText is now being built with Lazarus 3.0, 1.209.0 built with it has been released.