search

flathub / org.chromium.Chromium

https://flathub.org/apps/details/org.chromium.Chromium
43 stars 25 forks source link

Bundle rust nightly #402

Closed bbhtt closed 1 month ago

bbhtt commented 3 months ago

The rust nightly extension on Flathub is deprecated and will no longer be built.

flathubbot commented 3 months ago

Started test build 124404

bbhtt commented 3 months ago

I suggest keeping x-checker disabled on rust nightly to avoid too many PRs.

bbhtt commented 3 months ago

It's getting stripped...

flathubbot commented 3 months ago

Build 124404 was cancelled

flathubbot commented 3 months ago

Started test build 124408

flathubbot commented 3 months ago

Build 124408 was cancelled

bbhtt commented 3 months ago

https://github.com/chromium/chromium/blob/b5703cf78c306937aad339786ac5f468b03de64e/build/config/rust.gni#L145 the toolchain_has_rust check is somehow failing. Maybe this is a matter of setting the correct library paths.

I don't see how else rustc-revision can be empty.

flathubbot commented 3 months ago

Started test build 124411

flathubbot commented 3 months ago

Build 124411 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/107371/org.chromium.Chromium.flatpakref
bbhtt commented 1 month ago

@refi64 please take a look at this, rust-nightly is now being converted to extra-data. Once that is published, chromium builds will fail due to the change in library paths and append-path.

refi64 commented 1 month ago

oof, is there a timeline for that? I was hoping to sync the version with chromium's instead of leaving it stuck via an external-data-checker change but I hadn't gotten around to it yet.

bbhtt commented 1 month ago

It's switched already.

refi64 commented 1 month ago

Welp guess wiring up the external data checker is future me's problem.

flathubbot commented 1 month ago

Started test build 134934

flathubbot commented 1 month ago

Build 134934 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/117966/org.chromium.Chromium.flatpakref
rany2 commented 1 month ago

Welp guess wiring up the external data checker is future me's problem.

This is how I'm doing it in UGC: https://github.com/flathub/io.github.ungoogled_software.ungoogled_chromium/blob/763f4e4bb5570fd42300de5723303ac838c18e5d/maint/update_version.sh#L66

refi64 commented 1 month ago

@bbhtt quick note, github never sends email updates when an issue body is edited, so I actually never noticed you added the background details into the original issue. perhaps useful to just add a separate comment for any major changes :sweat_smile: